-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protos #647
Update protos #647
Conversation
5c966f5
to
fbddd4a
Compare
Linter violations are fixed in #651 |
sdk_name: "".to_string(), | ||
sdk_version: "".to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to set these to client_name
and client_version
from the client if they are different from the previous task (or remain empty/unset if they are the same).
The PR description says "See temporalio/features#321" but this doesn't solve #588 completely. Is this just a temporary thing until #588 can be properly addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's right. There's a little bit more work and testing required for that because we need to be watching for changes from task-to-task, rather than sending the same value repeatedly. So that's #588. This PR is just for unblocking Typescript work so I was thinking that it's fine to merge this as-is since these changes will result in transmitting the protobuf default zero-values, which is what the server is already using.
fbddd4a
to
1733afe
Compare
Update protos (needed for Typescript Update work).
This PR sets the new
sdk_name
andsdk_version
fields to their zero values. See #588